Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #445, update to meet standard #446

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

avan989
Copy link

@avan989 avan989 commented May 31, 2024

fix #445,

  1. update CF_DoSuspRes to increment the command counter and issue an info event instead of an error event.
  2. Update the Enable_engine command to increment the cmd counter when the state stays the same and issue info event.
  3. Update Disable engine command to increment cmd counter when stat stays the same and issue info event.

Checklist (Please check before submitting)

Describe the contribution
A clear and concise description of what the contribution is.
Fixes #445, Update Suspend/Resume/Enable_engine/Disable_engine to conform to standard

Testing performed
Steps taken to test the contribution:

  1. Build

  2. Send Command

  3. See info event and verify cmd counter increment

  4. Build For unit test

  5. Verify all cases pass and lcov is still 100%

Expected behavior changes
A clear and concise description of how this contribution will change behavior and level of impact.

  • API Change: xxx (if applicable)
  • Behavior Change: xxx (if applicable)
  • Or no impact to behavior

System(s) tested on

  • Hardware: [e.g. PC, SP0, MCP750]
  • OS: [e.g. Ubuntu 18.04, RTEMS 4.11, VxWorks 6.9]
  • Versions: [e.g. cFE 6.6, OSAL 4.2, PSP 1.3 for mcp750, any related apps or tools]

Additional context
Add any other context about the contribution here.

Third party code
If included, identify any third party code and provide text file of license

Contributor Info - All information REQUIRED for consideration of pull request
Full name and company/organization/center of all contributors ("Personal" if individual work)

  • Note CLA's apply to software contributions.
    Anh Van, GSFC

@avan989 avan989 force-pushed the fix-445-standardization-cmd-respond branch 2 times, most recently from e305cd3 to 0aeece8 Compare May 31, 2024 13:19
@dmknutsen dmknutsen added the CCB:Ready Ready for discussion at the Configuration Control Board (CCB) label Jun 5, 2024
@dzbaker
Copy link
Contributor

dzbaker commented Jun 27, 2024

CCB 27 June 2024: Will review at CCB once Event ID Naming PRs have been merged.

@avan989 avan989 force-pushed the fix-445-standardization-cmd-respond branch 2 times, most recently from 2b92235 to a3d9b90 Compare August 5, 2024 11:18
Fix nasa#445, update CF_DoSuspRes to increment command counter and issue info event instead of error event. Update Enable_engine command to increment cmd counter when state stays the same. Update Disable engine command to increment cmd counter when stat stays the same.
@avan989 avan989 force-pushed the fix-445-standardization-cmd-respond branch from a3d9b90 to 9b07112 Compare August 5, 2024 11:20
@dzbaker dzbaker added CCB:Approved and removed CCB:Ready Ready for discussion at the Configuration Control Board (CCB) labels Aug 8, 2024
@dzbaker dzbaker merged commit cc22558 into nasa:main Aug 8, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Standardization of Command Responses
3 participants